Integration Candidate COMBINED 2020-04-29 and 2020-05-06 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects a format mismatch warning on some platforms.
Do not assume CFE_SB_MsgId_t is implicitly integral in nature. When an integer value is required for printing or backward compatibility, use the explicit conversion routine to get this.
Fix #60, incorrect conversion specifier
Fix #53, Opaque CFE_SB_MsgId_t values
The FSW code relies on the message being pre-initalized which needs to be done explicitly in unit test code.
|
@astrogeco - squash and fix the commit message for all the #58 changes? |
astrogeco
force-pushed
the
integration-candidate
branch
from
97678bd
to
949e89a
Compare
astrogeco
changed the title
astrogeco
force-pushed
the
integration-candidate
branch
from
949e89a
to
78b1bd9
Compare
astrogeco
force-pushed
the
integration-candidate
branch
from
78b1bd9
to
155a3e7
Compare
astrogeco
force-pushed
the
integration-candidate
branch
from
d1cca13
to
6c3972b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Integration Candidate COMBINED 2020-04-29 and 2020-05-06
Fix #53,
Fix #60,
Fix #64
Testing performed
See PRs
Bundle CI - https://travis-ci.com/github/nasa/cFS/builds/165726730
Expected behavior changes
PR #54 - Applies the CFE_SB_MsgIdToValue() and CFE_SB_ValueToMsgId() routines where compatibility with an integer MsgId is necessary - syslog prints, events, compile-time MID #define values.
PR #61 - No more format conversion error in RTEMS build
System(s) tested on
See PRs
Additional context
Part of nasa/cFS#83
Contributor Info - All information REQUIRED for consideration of pull request
Elizabeth Timmons, NASA-GSFC
Jacob Hageman, NASA-GSFC
Joseph Hickey, Vantage Systems, Inc.