General SAMPLE App cleanup #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration Candidate 20200226
Update SAMPLE to better correlate with the naming conventions used elsewhere and documented in the CFE naming conventions - Put all global runtime data into a single "SAMPLE_AppData" object - Name all global-scope identifiers consistently with a "SAMPLE_" prefix - Do not use SAMPLE prefix for members already inside global - Command handlers named to match the command they process - Command handlers return an int32 status value - Telemetry payload defined in a separate structure - Member names in telemetry struct following convention in the CFE naming convention document.
Put the HkTlm buffer into a union to ensure it is aligned appropriately for conversion to a CFE_SB_Msg_t type.
jphickey
force-pushed
the
fix-38-msg-buffer-union
branch
from
07fbad9
to
01dd21a
Compare
|
NOTE: Rebased to 20200226 baseline and resolved conflicts. Latest commit is 01dd21a. |
skliper
approved these changes
Mar 2, 2020
|
CCB Fast Tracked - Reviewed by J. Hageman |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #38
Fixes #40
Applies a consistent naming convention for all symbols in SAMPLE App to be consistent with the published CFE naming convention and other CFE/CFS modules.
Testing performed
Build code with
SIMULATION=native ENABLE_UNIT_TESTS=TRUEand confirm that code builds without error or warnings. Also build on Raspberry Pi and confirm the cast align warnings are gone.Execute CFE and confirm nominal operation - all apps load and respond to basic commands as expected.
Expected behavior changes
No impact to behavior
System(s) tested on
Ubuntu 18.04 LTS, 64 bit
Raspberry Pi 3B+
Additional context
This single pull requests addresses multiple issues because they cannot be parallelized without introducing conflicts (the latter depends on the former). The fixes are kept as separate commits for review purposes.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.