Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample_app Integration candidate: Equuleus-rc1+dev8 #231

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

dzbaker
Copy link
Contributor

@dzbaker dzbaker commented Mar 21, 2024

Checklist (Please check before submitting)

Describe the contribution

Testing performed
cFS Bundle Checks
PSP Checks

Expected behavior changes
See PRs

System(s) tested on
Ubuntu 22.04

Additional context
Add any other context about the contribution here.

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
@thnkslprpt

@@ -107,10 +107,10 @@
/* Initialization */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * **/
int32 SAMPLE_APP_Init(void)
CFE_Status_t SAMPLE_APP_Init(void)

Check notice

Code scanning / CodeQL-coding-standard

Function too long Note

SAMPLE_APP_Init has too many lines (97, while 60 are allowed).
@@ -107,10 +107,10 @@
/* Initialization */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * **/
int32 SAMPLE_APP_Init(void)
CFE_Status_t SAMPLE_APP_Init(void)

Check notice

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
@dzbaker dzbaker merged commit ceaf7ab into main Mar 21, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants