Fix #110, Apply message alignment pattern #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
enhancement
sample_app Integration Candidate: 2020-11-24
|
CCB 2020-12-02 APPROVED |
skliper
added a commit
to skliper/cFS
that referenced
this pull request
Dec 3, 2020
- Replace CFE_SB_RcvMsg with CFE_SB_ReceiveBuffer - Use CFE_SB_Buffer_t for receiving and casting to command types - Use CFE_MSG_CommandHeader_t and CFE_MSG_TelemetryHeader_t in command and telemetry type definitions - Use CFE_SB_TransmitMsg to copy the command and telemetry into a CFE_SB_Buffer_t and send it where needed - Avoids need to create send buffers within the app (or union the packet types with CFE_SB_Buffer_t) - Eliminates references to CFE_SB_CmdHdr_t and CFE_SB_TlmHdr_t that formerly enforced alignment since these had potential to change the actual packet sizes - No need to cast to CFE_MSG_Message_t anywhere since it's available in the CFE_SB_Buffer_t union - Replaced CFE_MSG_Size_t with size_t
skliper
force-pushed
the
fix110-alignment-pattern
branch
from
172f86c
to
4deac06
Compare
|
@astrogeco rebased and resolved. |
skliper
added a commit
to skliper/cFS
that referenced
this pull request
Dec 3, 2020
astrogeco
removed
the
CCB:Ready
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Dec 8, 2020
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #110
command and telemetry type definitions
into a CFE_SB_Buffer_t and send it where needed
the packet types with CFE_SB_Buffer_t)
that formerly enforced alignment since these had potential
to change the actual packet sizes
available in the CFE_SB_Buffer_t union
Testing performed
Bundle CI, unit tests, spot checked cmd/tlm
Expected behavior changes
None, pattern applied only
System(s) tested on
Additional context
Depends on nasa/cFE#1015
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC