Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table type should be defined once in table header file #17

Closed
skliper opened this issue Nov 1, 2019 · 1 comment · Fixed by #20
Closed

Table type should be defined once in table header file #17

skliper opened this issue Nov 1, 2019 · 1 comment · Fixed by #20
Assignees
@skliper
Labels
bug Something isn't working
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Nov 1, 2019

Is your feature request related to a problem? Please describe.
SampleTable_t is defined in both sample_app_msg.h and sample_table.c

Describe the solution you'd like
Define sample_table.h, and include where needed.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper self-assigned this Nov 1, 2019
@skliper
Copy link
Contributor Author

skliper commented Nov 1, 2019

May need dev guide update

@skliper skliper mentioned this issue Nov 1, 2019
Merged
skliper added a commit that referenced this issue Nov 15, 2019
@skliper
CCB 20191106: Merge #18
2a8e764 
Fixes #17
Code reviewed and approved at 20191106 CCB
@skliper skliper mentioned this issue Nov 19, 2019
Merged
@skliper skliper added the enhancement New feature or request label Dec 30, 2019
@skliper skliper added this to the 1.2.0 milestone Dec 30, 2019
@astrogeco astrogeco added bug Something isn't working and removed enhancement New feature or request labels Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
bug Something isn't working
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Integration Candidate 20191115 nasa/sample_app
2 participants
@skliper @astrogeco