Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First parameter to add_cfe_tables should be app name #148

Open
jphickey opened this issue May 17, 2021 · 0 comments
Open

First parameter to add_cfe_tables should be app name #148

jphickey opened this issue May 17, 2021 · 0 comments
Assignees
Labels

Comments

@jphickey
Copy link
Contributor

Describe the bug
The add_cfe_tables function is declared as follows in arch_build.cmake:
function(add_cfe_tables APP_NAME TBL_SRC_FILES)

The first parameter was intended to be the application name that the table is associated with, but historically any string was accepted since the string just served to make a unique target name.

To Reproduce
Sample_app always passes the string sampleAppTable here.

Expected behavior
Should pass sample_app as first argument.

Code snips

add_cfe_tables(sampleAppTable fsw/tables/sample_app_tbl.c)

System observed on:
Ubuntu

Additional context
No major issue with the current build system, but will may become an issue if/when nasa/cFE#1538 is implemented, and may also become an issue if directory-scope include directories are removed.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants