Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-compliant header guards #142

Closed
skliper opened this issue Mar 24, 2021 · 0 comments · Fixed by #143 or #145
Closed

Fix non-compliant header guards #142

skliper opened this issue Mar 24, 2021 · 0 comments · Fixed by #143 or #145
Assignees
@jphickey
Labels
enhancement New feature or request

Comments

@skliper
Copy link
Contributor

skliper commented Mar 24, 2021

Is your feature request related to a problem? Please describe.
Leading _ is reserved

Describe the solution you'd like
Replace with pattern used in OSAL

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added the enhancement New feature or request label Mar 24, 2021
@jphickey jphickey self-assigned this Mar 24, 2021
jphickey added a commit to jphickey/sample_app that referenced this issue Mar 24, 2021
@jphickey
Fix nasa#142, scrub header guards
8807208 
Use a consistent header guard on all sample app header files.
Also convert file-scope block comments to doxygen format.
@jphickey jphickey mentioned this issue Mar 24, 2021
Merged
jphickey added a commit to jphickey/sample_app that referenced this issue Mar 24, 2021
@jphickey
Fix nasa#142, scrub header guards
dbed84b 
Use a consistent header guard on all sample app header files.
Also convert file-scope block comments to doxygen format.
@astrogeco astrogeco mentioned this issue Mar 31, 2021
Merged
astrogeco added a commit that referenced this issue Mar 31, 2021
@astrogeco
Merge pull request #143 from jphickey/fix-142-header-guards
9075f23 
Fix #142, scrub header guards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@jphickey @skliper