Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osal Integration candidate: 2021-05-04 #979

Merged
merged 5 commits into from
May 5, 2021
Merged

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented May 3, 2021

Description

PR #973

Fix #964, UtPrintx function

Fixes infinite loop in UtPrintx(). Adds the data's memory address to output. Note, UtPrintf displays the the file/line of the UtPrintx function, not the actual test location; it is better to call UT_BSP_DoText directly.

PR #976

Fix #960, add socket shutdown implementation

Adds OS_SocketShutdown() API wrapper around BSD's socket shutdown() API. This allows a data transfer of a stream socket to be gracefully shut down prior to socket closure.

Context

Part of nasa/cFS#252

Testing

osal checks https://github.com/nasa/osal/pull/979/checks
cFS Bundle checks https://github.com/nasa/cFS/pull/252/checks

Authors

@jphickey

jphickey and others added 4 commits April 27, 2021 11:53
Fix the UtPrintx() routine such that the loop stops correctly.
Also improves the output to print the address, not just the data.

Note if UtPrintf is used, one sees the file/line of the UtPrintx
function, not the actual test location, so it is better to call
UT_BSP_DoText directly so it omits this extraneous info.
Adds an OS_SocketShutdown() wrapper around the BSD socket shutdown() API.
This allows a data transfer of a stream socket to be gracefully shut
down prior to socket closure.
Fix #960, add socket shutdown implementation
@astrogeco astrogeco self-assigned this May 5, 2021
@astrogeco astrogeco marked this pull request as ready for review May 5, 2021 18:14
@astrogeco astrogeco merged commit 706f0de into main May 5, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request May 5, 2021
cfe v6.8.0-rc1+dev559 and osal v5.1.0-rc1+dev417

Combines:

nasa/osal#979
nasa/cFE#1481

Includes:

nasa/osal#973, UtPrintx function
nasa/osal#976, add socket shutdown implementation

nasa/cFE#1418, add ES CDS Functional test
nasa/cFE#1429, Function comment blocks
nasa/cFE#1414, Add Header Functional tests.
nasa/cFE#1415, add Current Time Functional Test
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
jphickey added a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Add the task info and priority to the data structure written by
the QUERY_ALL_TASKS command.  Leaving out entry point, as it would
be a memory address and not useful/relevant outside the process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why does UtPrintx have an infinite loop in it? Add socket shutdown API
3 participants