-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #752, Utilize UTASSERT_CASETYPE_NA to report OS_ERR_NOT_IMPLEMENTED #816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also needs update:
osal/src/tests/symbol-api-test/symbol-api-test.c
Lines 46 to 68 in ff4f523
/* | |
** dump the symbol table with a 32768 byte limit | |
*/ | |
UtPrintf("Dumping symbol table with a limit of 32768 bytes\n"); | |
status = OS_SymbolTableDump("/ram/SymbolTable32k.dat", 32768); | |
UtAssert_True(status == OS_SUCCESS || status == OS_ERR_NOT_IMPLEMENTED, "status after 32k OS_SymbolTableDump = %d", | |
(int)status); | |
/* | |
** dump the symbol table with a 128k byte limit | |
*/ | |
UtPrintf("Dumping symbol table with a limit of 131072 bytes\n"); | |
status = OS_SymbolTableDump("/ram/SymbolTable128k.dat", 131072); | |
UtAssert_True(status == OS_SUCCESS || status == OS_ERR_NOT_IMPLEMENTED, "status after 128k OS_SymbolTableDump = %d", | |
(int)status); | |
/* | |
** dump the symbol table with a 512k byte limit | |
*/ | |
UtPrintf("Dumping symbol table with a limit of 524288 bytes\n"); | |
status = OS_SymbolTableDump("/ram/SymbolTable512k.dat", 524288); | |
UtAssert_True(status == OS_SUCCESS || status == OS_ERR_NOT_IMPLEMENTED, "status after 512k OS_SymbolTableDump = %d", | |
(int)status); |
9004e4c
to
ebef88b
Compare
ebef88b
to
f92d6f4
Compare
CCB 2021-02-17 Make a macro to replace multiple instances of "copy-pasted" code |
This was rejected in favor of making a macro and using it in all these cases (could be done as part of #787 or independent) |
Integration Candidate 2020-08-12
Describe the contribution
(would have fixed #752)
use UTASSERT_CASETYPE_NA instead of UtPrintf to report cases when not implemented
Testing performed
Build and run unit test
Expected behavior changes
No impact to behavior
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC