Fix #707 change sem flush to solve race condition #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanzaben
added
the
CCB:Ready
jphickey
approved these changes
Dec 30, 2020
|
So far so good ... I pulled this into my OSAL baseline and ran the full test cycle several times and haven't seen it get stuck or fail yet. (Would happen at least 1 in 3 runs previously). |
|
Update comment message to follow preferred format: Right now it looks like: |
change sem flush to solve race condition change port numbers to be different from network test
zanzaben
force-pushed
the
fix707_Select_Test_Race_condition
branch
from
15de179 to
ae888d4
Compare
skliper
approved these changes
Jan 6, 2021
astrogeco
removed
the
CCB:Ready
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jan 6, 2021
This was referenced Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
fixes #707
Removed Sem flush and changed it to sem give to prevent a rare race condition.
Change the port numbers to be different from network test for when test are run in parallel.
Testing performed
Ran the unit tests in parallel
Expected behavior changes
Test shouldn't lock or fail
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC