Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #491, increase UT assert buffer sizes #492

Merged

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Jun 8, 2020

Describe the contribution
The buffer for context info increases from 128 to 256 bytes and the total report buffer to 320 bytes.

Fixes #491

Testing performed
Build and Execute all unit tests.

Expected behavior changes
Confirmed that long report lines that had been truncated are no longer truncated.

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jun 8, 2020
@astrogeco
Copy link
Contributor

CCB 2020-06-10: APPROVED

@astrogeco astrogeco added CCB-20200610 CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jun 10, 2020
astrogeco and others added 2 commits June 10, 2020 19:24
The buffer for context info increases from 128 to 256 bytes
@jphickey jphickey force-pushed the fix-491-utassert-line-length branch from 909d63a to 2d79f8e Compare June 16, 2020 14:54
@jphickey
Copy link
Contributor Author

Updated to only fix UtAssertEx function here in this PR. The output function in utbsp.c is changed in issue #501. Taking it out of this PR avoids conflict.

@astrogeco astrogeco changed the base branch from master to integration-candidate June 16, 2020 20:28
@astrogeco astrogeco merged commit e05cb2c into nasa:integration-candidate Jun 17, 2020
@jphickey jphickey deleted the fix-491-utassert-line-length branch June 19, 2020 16:13
@skliper skliper added this to the 5.1.0 milestone Aug 21, 2020
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow longer messages in UT assert
4 participants