Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #397, Remove old unit test example, add README.md, further macro cleanup #405

Merged
merged 3 commits into from
Apr 15, 2020
Merged

Fix #397, Remove old unit test example, add README.md, further macro cleanup #405

merged 3 commits into from
Apr 15, 2020

Conversation

CDKnightNASA
Copy link
Contributor

@CDKnightNASA CDKnightNASA commented Apr 3, 2020 •
edited by astrogeco
Loading

Describe the contribution
Removes outdated unit test examples, adds macros for concise and clear unit tests, converted binsem unit tests to new macros.

Fix #397

Testing performed
Built unit tests and executed.

Expected behavior changes
Same behavior, concise code.

System(s) tested on
Debian 9.

Contributor Info - All information REQUIRED for consideration of pull request
[email protected]

@CDKnightNASA CDKnightNASA self-assigned this Apr 3, 2020
@CDKnightNASA CDKnightNASA added enhancement CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) unit-test Tickets related to the OSAL unit testing (functional and/or coverage) labels Apr 3, 2020
@CDKnightNASA CDKnightNASA linked an issue Apr 3, 2020 that may be closed by this pull request
simplify unit tests with utassert.h macros #397
Closed
This was referenced Apr 3, 2020
Closed
Closed
jphickey
jphickey approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

@astrogeco astrogeco changed the title fix #397 - removed old example, add README.md, further macro cleanup Fix #397, removed old example, add README.md, further macro cleanup Apr 7, 2020
@astrogeco astrogeco changed the title Fix #397, removed old example, add README.md, further macro cleanup Fix #397, Remove old unit test example, add README.md, further macro cleanup Apr 7, 2020
@astrogeco
Copy link
Contributor

CCB 20200408 - APPROVED

@astrogeco astrogeco added CCB - 20200408 CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 8, 2020
@jphickey jphickey mentioned this pull request Apr 9, 2020
Closed
@astrogeco astrogeco changed the base branch from master to integration-candidate April 14, 2020 21:25
@astrogeco
Copy link
Contributor

@CDKnightNASA there's some conflicts here, can you resolve them?

@astrogeco astrogeco merged commit ed2755e into nasa:integration-candidate Apr 15, 2020
@astrogeco astrogeco mentioned this pull request Apr 15, 2020
Merged
@skliper skliper added this to the 5.1.0 milestone Jun 1, 2020
@astrogeco astrogeco removed enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage) labels Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jphickey jphickey jphickey approved these changes

@skliper skliper skliper approved these changes

Assignees

@CDKnightNASA CDKnightNASA

Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.

simplify unit tests with utassert.h macros
4 participants
@CDKnightNASA @astrogeco @jphickey @skliper