Fix #18, Deprecate shared memory APIs #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
enhancement
CCB:Ready
Integration Candidate 2020-03-18
skliper
force-pushed
the
fix18-deprecate-shmem
branch
from
aedd033
to
592328b
Compare
|
Rebased on current master |
|
CCB 2020-04-01 - APPROVED |
astrogeco
added
CCB - 20200401
CCB:Approved
astrogeco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
This just wraps OS_ShMem* prototype and unit test wrapper additions in OSAL_OMIT_DEPRECATED.
Fixes #18
Testing performed
Steps taken to test the contribution:
Expected behavior changes
Only impact would be to an OSAL that implements these APIs and compiles with OSAL_OMIT_DEPRECATED defined. None of the framework APIs do. Path forward would be for that OSAL to own the prototype, or split into a separate library, or however else you want to handle it.
System(s) tested on
Additional context
Only aedd033 is relevant to this request, I can rebase once the other changes are merged.
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC