Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #305, Resolve cppcheck warning ut_stubs #306

Merged
merged 1 commit into from
Dec 30, 2019
Merged

issue #305, Resolve cppcheck warning ut_stubs #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ut-stubs/osapi-utstub-file.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ static int32 UT_GenericWriteStub(const char *fname, UT_EntryKey_t fkey, const vo
*****************************************************************************/
int32 OS_creat(const char *path, int32 access)
{
int32 status = OS_SUCCESS;
int32 status;

status = UT_DEFAULT_IMPL(OS_creat);

Expand Down Expand Up @@ -144,7 +144,7 @@ int32 OS_open(const char *path, int32 access, uint32 mode)
*****************************************************************************/
int32 OS_close(uint32 filedes)
{
int32 status = OS_FS_SUCCESS;
int32 status;

status = UT_DEFAULT_IMPL(OS_close);

Expand Down
4 changes: 2 additions & 2 deletions src/ut-stubs/osapi-utstub-mutex.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ int32 OS_MutSemDelete(uint32 sem_id)
******************************************************************************/
int32 OS_MutSemGive(uint32 sem_id)
{
int32 status = OS_SUCCESS;
int32 status;

status = UT_DEFAULT_IMPL(OS_MutSemGive);

Expand Down Expand Up @@ -153,7 +153,7 @@ int32 OS_MutSemGive(uint32 sem_id)
******************************************************************************/
int32 OS_MutSemTake(uint32 sem_id)
{
int32 status = OS_SUCCESS;
int32 status;

status = UT_DEFAULT_IMPL(OS_MutSemTake);

Expand Down
8 changes: 4 additions & 4 deletions src/ut-stubs/osapi-utstub-queue.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ int32 OS_QueueCreate(uint32 *queue_id,
uint32 data_size,
uint32 flags)
{
int32 status = OS_SUCCESS;
int32 status;

status = UT_DEFAULT_IMPL(OS_QueueCreate);

Expand Down Expand Up @@ -99,7 +99,7 @@ int32 OS_QueueCreate(uint32 *queue_id,
******************************************************************************/
int32 OS_QueueDelete(uint32 queue_id)
{
int32 status = OS_SUCCESS;
int32 status;

status = UT_DEFAULT_IMPL(OS_QueueDelete);

Expand Down Expand Up @@ -142,7 +142,7 @@ int32 OS_QueueGet(uint32 queue_id,
uint32 *size_copied,
int32 timeout)
{
int32 status = OS_SUCCESS;
int32 status;

status = UT_DEFAULT_IMPL(OS_QueueGet);

Expand Down Expand Up @@ -183,7 +183,7 @@ int32 OS_QueueGet(uint32 queue_id,
******************************************************************************/
int32 OS_QueuePut(uint32 queue_id, const void *data, uint32 size, uint32 flags)
{
int32 status = OS_SUCCESS;
int32 status;

status = UT_DEFAULT_IMPL(OS_QueuePut);

Expand Down
6 changes: 3 additions & 3 deletions src/ut-stubs/osapi-utstub-task.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ int32 OS_TaskCreate(uint32 *task_id, const char *task_name,
uint32 stack_size, uint32 priority,
uint32 flags)
{
int32 status = OS_SUCCESS;
int32 status;

UT_Stub_RegisterContext(UT_KEY(OS_TaskCreate), &function_pointer);
UT_Stub_RegisterContext(UT_KEY(OS_TaskCreate), stack_pointer);
Expand Down Expand Up @@ -154,7 +154,7 @@ int32 OS_TaskDelay(uint32 millisecond)
*****************************************************************************/
int32 OS_TaskSetPriority (uint32 task_id, uint32 new_priority)
{
int32 status = OS_SUCCESS;
int32 status;

status = UT_DEFAULT_IMPL(OS_TaskSetPriority);

Expand All @@ -179,7 +179,7 @@ int32 OS_TaskSetPriority (uint32 task_id, uint32 new_priority)
******************************************************************************/
int32 OS_TaskRegister(void)
{
int32 status = OS_SUCCESS;
int32 status;

status = UT_DEFAULT_IMPL(OS_TaskRegister);

Expand Down
4 changes: 2 additions & 2 deletions src/ut-stubs/utstub-helpers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@ void UT_CheckForOpenSockets(void)
UT_ObjTypeState_t *StatePtr;
uint32 i;
uint32 id;
uint32 InUse = 0;

StatePtr = &UT_ObjState[UT_OBJTYPE_QUEUE];
for (i=0; i <= StatePtr->LastIssueNumber; ++i)
Expand All @@ -191,10 +190,11 @@ void UT_CheckForOpenSockets(void)
{
id = i;
UT_FIXUP_ID(id, UT_OBJTYPE_QUEUE);

UtAssert_Failed("UT_Queue %d left open. ID=%x\n", (int)i, (unsigned int)id);
++InUse;
}
}

}