Fix #272: use 4K stack for sem-speed-test tasks #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On VxWorks, no minimum stack size is implemented, and the implementation will create tasks with an extremely small stack if "0" is passed in. This causes the worker tasks to overrun the stack on Vxworks, triggering undefined/inconsistent behavior.
skliper
approved these changes
Oct 29, 2019
|
looks good to me. |
ghost
approved these changes
Oct 29, 2019
|
CCB 20191030: Code reviewed and approved |
skliper
added
the
CCB:Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix issue #272
Use a nonzero stack size for this test.
Testing performed
Build and execute "sem-speed-test" on the MPC750 VxWorks platform.
Expected behavior changes
Test now runs and passes reliably with no odd/inconsistent behaviors
System(s) tested on:
MPC750 VxWorks 6.9
Contributor Info
Joseph Hickey, Vantage Systems, Inc.