Fix #1173, separate append on volume_name to system_mountpt #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generating the system_mountpt string via a single call to snprintf triggered a compiler warning about overlapping memory. However this does not seem like a real warning, as the volume_name should always be null terminated before the overlap would be possible. By separating this to be a separate append of the volume_name along with an explicit size check to ensure the buffers indeed do not overlap, this avoids the warning.
jphickey
added
the
CCB:Ready
dzbaker
added
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jan 26, 2023
*Combines:* osal v6.0.0-rc4+dev184 **Includes:** *osal* - nasa/osal#1355 Co-authored by: Joseph Hickey <[email protected]>
This was referenced Jan 26, 2023
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jan 26, 2023
*Combines:* osal v6.0.0-rc4+dev184 **Includes:** *osal* - nasa/osal#1355 Co-authored by: Joseph Hickey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Generating the system_mountpt string via a single call to snprintf triggered a compiler warning about overlapping memory. However this does not seem like a real warning, as the volume_name should always be null terminated before the overlap would be possible.
By separating this to be a separate append of the volume_name along with an explicit size check to ensure the buffers indeed do not overlap, this avoids the warning.
Fixes #1173
Testing performed
Build and run all tests
Expected behavior changes
Avoids a false compiler warning about possible pointer overlap by explicitly checking and limiting the string length being appended.
No functional change, as the generated "system_mountpt" string should be identical.
System(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.