Fix #1184, Static Analysis Add Duplicate and Remove Main Push #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArielSAdamsNASA
added
CCB:Ready
skliper
approved these changes
Oct 22, 2021
Looking into it. For some reason it is only broken for CodeQL OSAL and not cFE. |
|
@skliper I don't know why it is broken, but I know how to fix it. There are two options. One is changing the codeql-coding-standard.yml in cFS to use nasa/cFS/.github/codeql/jpl-misra.qls@main as seen here: https://github.com/ArielSAdamsNASA/osal/actions/runs/1372651054 The second option is to create a local jpl-misra.qls file in OSAL as seen here: https://github.com/ArielSAdamsNASA/osal/actions/runs/1372677254 |
|
@ArielSAdamsNASA I suggest using the cFS one |
ArielSAdamsNASA
removed
the
CCB:Ready
|
Fixed by #1190. |
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#1185, Squash possible uninitialized variable false alarms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #1184
Testing performed
Forked repo, https://github.com/ArielSAdamsNASA/osal/actions/runs/1372520583.
Expected behavior changes
Static analysis workflow should run on all branches for both pull requests and push. The duplicate job prevents two instances of the static analysis to run at the same time. Pull requests are prioritized.
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal