Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1452, Remove softsleep, as a dead store. #1146

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

thesamprice
Copy link

Describe the contribution
A clear and concise description of what the contribution is.

  • Removes softsleep, as it doesnt appear to be used.

Testing performed
Steps taken to test the contribution:

  1. Run through your ci pipeline

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

  • Or no impact to behavior

System(s) tested on

  • Hardware: [e.g. PC, SP0, MCP750]
  • OS: [e.g. Ubuntu 18.04, RTEMS 4.11, VxWorks 6.9]
  • Versions: [e.g. cFE 6.6, OSAL 4.2, PSP 1.3 for mcp750, any related apps or tools]

Additional context
Deleting code

Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)

  • If NASA Civil Servant Employee or GSFC Contractor on SES II
    • Address/email/phone and contract/task information (if applicable) must be on file

@skliper skliper added this to the cFS-Draco milestone Sep 9, 2021
Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth an issue and discussion. I'd like to try and understand/document what the intent was before deleting (maybe it's future work to use it or related to another issue?)

@skliper skliper removed this from the Draco milestone Mar 18, 2022
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
@dzbaker dzbaker self-assigned this Sep 8, 2022
@thnkslprpt
Copy link
Contributor

Worth an issue and discussion. I'd like to try and understand/document what the intent was before deleting (maybe it's future work to use it or related to another issue?)

Looks like the functionality that used softsleep was removed back in 2019 with issue #271.

Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. "softsleep" was an alternative timing mode that would simply call clock_nanosleep() with an interval timer value adjusted by sampling clock_gettime() with each tick. This would create a stable metronome (drift compensated) without requiring an interrupt or signal from the kernel.

This structure member was used to store the previous clock sample so the difference/time to next tick could be calculated.

As most systems do provide a facility to configure a timing interrupt or signal, the softsleep option wasn't used and the code was removed years ago, but this structure member and the call to clock_gettime() must have been overlooked.

@dzbaker
Copy link
Collaborator

dzbaker commented Oct 20, 2022

@thesamprice CCB 20 October 2022: Approved pending resolution of conflicts.

@dzbaker dzbaker added the CCB:Approved Indicates code review and approval by community CCB label Oct 20, 2022
@thesamprice
Copy link
Author

I probably wont get to resolving these conflicts anytime soon.
Its not effecting my use cases.

@thesamprice
Copy link
Author

I wont get to this for a while, its not impacting any of my functionality.
I spotted it a year ago and mentioned, but have some fires i'm fighting now.

@dzbaker dzbaker added this to the Equuleus milestone Jan 26, 2023
@dzbaker dzbaker changed the title Remove softsleep, as a dead store. Fix #1452, Remove softsleep, as a dead store. Feb 23, 2024
@dzbaker dzbaker linked an issue Feb 23, 2024 that may be closed by this pull request
dzbaker added a commit to nasa/cFS that referenced this pull request Feb 23, 2024
*Combines:*

cFE equuleus-rc1+dev96
osal equuleus-rc1+dev53
to_lab equuleus-rc1+dev44

**Includes:**

*cFE*
- nasa/cFE#2515
- nasa/cFE#2330

*osal*
- nasa/osal#1448
- nasa/osal#1146
- nasa/osal#1357
- nasa/osal#1354
- nasa/osal#1331

*to_lab*
- nasa/to_lab#191
- nasa/to_lab#136

Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Avi Weiss <[email protected]>
Co-authored by: Sam Price <[email protected]>
@dzbaker dzbaker merged commit fff0725 into nasa:main Feb 23, 2024
dzbaker added a commit to nasa/cFS that referenced this pull request Feb 23, 2024
*Combines:*

cFE equuleus-rc1+dev96
osal equuleus-rc1+dev53
to_lab equuleus-rc1+dev44

**Includes:**

*cFE*
- nasa/cFE#2515
- nasa/cFE#2330

*osal*
- nasa/osal#1448
- nasa/osal#1146
- nasa/osal#1357
- nasa/osal#1354
- nasa/osal#1331

*to_lab*
- nasa/to_lab#191
- nasa/to_lab#136

Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Avi Weiss <[email protected]>
Co-authored by: Sam Price <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Softsleep is no longer used
5 participants