-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1452, Remove softsleep, as a dead store. #1146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth an issue and discussion. I'd like to try and understand/document what the intent was before deleting (maybe it's future work to use it or related to another issue?)
Fix nasa#1145, Update workflow action badge
Looks like the functionality that used softsleep was removed back in 2019 with issue #271. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine. "softsleep" was an alternative timing mode that would simply call clock_nanosleep()
with an interval timer value adjusted by sampling clock_gettime()
with each tick. This would create a stable metronome (drift compensated) without requiring an interrupt or signal from the kernel.
This structure member was used to store the previous clock sample so the difference/time to next tick could be calculated.
As most systems do provide a facility to configure a timing interrupt or signal, the softsleep option wasn't used and the code was removed years ago, but this structure member and the call to clock_gettime()
must have been overlooked.
@thesamprice CCB 20 October 2022: Approved pending resolution of conflicts. |
I probably wont get to resolving these conflicts anytime soon. |
I wont get to this for a while, its not impacting any of my functionality. |
*Combines:* cFE equuleus-rc1+dev96 osal equuleus-rc1+dev53 to_lab equuleus-rc1+dev44 **Includes:** *cFE* - nasa/cFE#2515 - nasa/cFE#2330 *osal* - nasa/osal#1448 - nasa/osal#1146 - nasa/osal#1357 - nasa/osal#1354 - nasa/osal#1331 *to_lab* - nasa/to_lab#191 - nasa/to_lab#136 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Avi Weiss <[email protected]> Co-authored by: Sam Price <[email protected]>
*Combines:* cFE equuleus-rc1+dev96 osal equuleus-rc1+dev53 to_lab equuleus-rc1+dev44 **Includes:** *cFE* - nasa/cFE#2515 - nasa/cFE#2330 *osal* - nasa/osal#1448 - nasa/osal#1146 - nasa/osal#1357 - nasa/osal#1354 - nasa/osal#1331 *to_lab* - nasa/to_lab#191 - nasa/to_lab#136 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Avi Weiss <[email protected]> Co-authored by: Sam Price <[email protected]>
Describe the contribution
A clear and concise description of what the contribution is.
Testing performed
Steps taken to test the contribution:
Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
System(s) tested on
Additional context
Deleting code
Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)