Fix #1133, Disable Unit Tests in CodeQL #1134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArielSAdamsNASA
added
CCB:Ready
|
Closing since we want to keep static analysis on ut code to encourage good coding practices |
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#1134, Add UtDebug output to CFE_ES_WriteToSysLog stub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #1133
Testing performed
Tested on forked repo: https://github.com/ArielSAdamsNASA/osal/security/code-scanning?query=branch%3AUnit-test-off
Expected behavior changes
Disabled unit tests for both CodeQL workflows. Shows less code scanning alerts with it disabled. Alerts should only be shown for flight code.
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal