Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused SCRIPT_MODE definition #934

Closed
skliper opened this issue Mar 26, 2021 · 0 comments · Fixed by #935 or #927
Closed

Remove unused SCRIPT_MODE definition #934

skliper opened this issue Mar 26, 2021 · 0 comments · Fixed by #935 or #927
Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Mar 26, 2021

Is your feature request related to a problem? Please describe.
The following define no longer does anything:

osal/src/tests/CMakeLists.txt

Lines 11 to 13 in 53f7f61

# The original OSAL tests ran forever until CTRL+C, this does not work for scripted testing
# This SCRIPT_MODE define plus some hooks in the code allow for limited runs
add_definitions(-DSCRIPT_MODE)

Describe the solution you'd like
Remove

Describe alternatives you've considered
None

Additional context
Likely OBE from transition to the osal/ut_assert

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Mar 26, 2021
@skliper skliper added this to the 6.0.0 milestone Mar 26, 2021
skliper added a commit to skliper/osal that referenced this issue Mar 26, 2021
@skliper
Fix nasa#934, Remove unused SCRIPT_MODE flag
054165a
@skliper skliper mentioned this issue Mar 26, 2021
Merged
@astrogeco astrogeco mentioned this issue Mar 31, 2021
Merged
astrogeco added a commit that referenced this issue Mar 31, 2021
@astrogeco
Merge pull request #935 from skliper/fix934-rm_script_mode
3d3fe01 
Fix #934, Remove unused SCRIPT_MODE flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Milestone
Caelum
1 participant
@skliper