Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments on header guard endif don't match ifdef #916

Closed
skliper opened this issue Mar 17, 2021 · 2 comments · Fixed by #931 or #951
Closed

Comments on header guard endif don't match ifdef #916

skliper opened this issue Mar 17, 2021 · 2 comments · Fixed by #931 or #951
Assignees
@jphickey
Labels
enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Mar 17, 2021

Is your feature request related to a problem? Please describe.
For example:

osal/src/os/inc/common_types.h

Lines 31 to 32 in ead5723

#ifndef COMMON_TYPES_H
#define COMMON_TYPES_H

osal/src/os/inc/common_types.h

Line 191 in ead5723

#endif /* _common_types_ */

Describe the solution you'd like
Comments should be consistent w/ code

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@iprasandeep
Copy link

Hi @skliper Can I work on this issue if it's open??

@skliper
Copy link
Contributor Author

skliper commented Mar 25, 2021

@prsndp Thanks for the offer, but I think a script was just put together to automate this fix.

@skliper skliper removed the good first issue Good for newcomers label Mar 25, 2021
@skliper skliper added this to the 6.0.0 milestone Mar 25, 2021
jphickey added a commit to jphickey/osal that referenced this issue Mar 25, 2021
@jphickey
Fix nasa#916, scrub headers in src/bsp and src/os
f98c1e4 
Ensure all headers have a consistent include guard and file block comment
This gets all FSW code within src/os and src/bsp.
jphickey added a commit to jphickey/osal that referenced this issue Mar 25, 2021
@jphickey
Fix nasa#916, scrub headers in src/bsp and src/os
6a3f0b7 
Ensure all headers have a consistent include guard and file block comment
This gets all FSW code within src/os and src/bsp.
jphickey added a commit to jphickey/osal that referenced this issue Mar 25, 2021
@jphickey
Fix nasa#916, scrub headers in unit tests and ut assert
fe5eb35 
Ensure all headers have a consistent include guard and file block comment
This gets all unit tests (function, not coverage) and ut assert
@jphickey jphickey mentioned this issue Mar 25, 2021
Merged
@jphickey jphickey linked a pull request Mar 25, 2021 that will close this issue
Fix #916, scrub include guards #931
Merged
jphickey added a commit to jphickey/osal that referenced this issue Mar 25, 2021
@jphickey
Fix nasa#916, scrub headers in unit-test-coverage
4ce8dec 
Scrub all include guards and file scope doxygen comments in
src/unit-test-coverage
jphickey added a commit to jphickey/osal that referenced this issue Mar 25, 2021
@jphickey
Fix nasa#916, remove remaining extraneous info
da1658e 
Filter out author and creation date info (not relevant)
astrogeco added a commit that referenced this issue Apr 8, 2021
@astrogeco
Merge pull request #931 from jphickey/fix-916-include-guards
a876519 
Fix #916, scrub include guards
@astrogeco astrogeco mentioned this issue Apr 8, 2021
Merged
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@yammajamma
Merge pull request nasa#916 from nasa/integration-candidate
8a7dc8f 
Integration Candidate: 2020-09-29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

Fix #916, scrub include guards jphickey/osal
osal Integration candidate: 2021-04-06 nasa/osal
3 participants
@jphickey @skliper @iprasandeep