Report timer_gettime error in OS_TimeBaseSet_Impl #889
Comments
jphickey
added a commit
to jphickey/osal
that referenced
this issue
Mar 15, 2021
In VxWorks the impl calls timer_settime followed by timer_gettime on the same timer to check if rounding occurred. If the second call fails this reports it as an error. Note unless there is some sort of OS bug this should be impossible to happen as this code only runs after a successful timer_settime.
jphickey
added a commit
to jphickey/osal
that referenced
this issue
Mar 15, 2021
In VxWorks the impl calls timer_settime followed by timer_gettime on the same timer to check if rounding occurred. If the second call fails this reports it as an error. Note unless there is some sort of OS bug this should be impossible to happen as this code only runs after a successful timer_settime.
astrogeco
added a commit
that referenced
this issue
Mar 22, 2021
Fix #889, report timer_gettime error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
If timer_gettime fails the rounding error will not be reported, silently ignored:
osal/src/os/vxworks/src/os-impl-timebase.c
Line 566 in ead5723
Describe the solution you'd like
Report error, return failure
Describe alternatives you've considered
None
Additional context
None
Requester Info
Jacob Hageman - NASA/GSFC, OSAL code review
The text was updated successfully, but these errors were encountered: