Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove impossible to reach (operationally) code #883

Closed
skliper opened this issue Mar 11, 2021 · 0 comments · Fixed by #899 or #917
Closed

Remove impossible to reach (operationally) code #883

skliper opened this issue Mar 11, 2021 · 0 comments · Fixed by #899 or #917
Assignees
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Mar 11, 2021

Is your feature request related to a problem? Please describe.
OS_MutSemTake_Impl will block until this thread owns the mutex, check would require OS error:

if (OS_ObjectIdDefined(mutex->last_owner))
{
OS_DEBUG("WARNING: Task %lu taking mutex %lu while owned by task %lu\n",
OS_ObjectIdToInteger(self_task), OS_ObjectIdToInteger(sem_id),
OS_ObjectIdToInteger(mutex->last_owner));
}

Describe the solution you'd like
Remove

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC, OSAL code review

@skliper skliper added this to the 6.0.0 milestone Mar 11, 2021
jphickey added a commit to jphickey/osal that referenced this issue Mar 12, 2021
The only way for this test happen would be if somehow the normal
unlock process was bypassed.
jphickey added a commit to jphickey/osal that referenced this issue Mar 12, 2021
The only way for this test happen would be if somehow the normal
unlock process was bypassed.
astrogeco added a commit that referenced this issue Mar 22, 2021
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
Fix nasa#882, Returned processor ID to default to unbreak toolchain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants