Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#define or configurable copy block size #875

Closed
skliper opened this issue Mar 10, 2021 · 0 comments · Fixed by #890 or #917
Closed

#define or configurable copy block size #875

skliper opened this issue Mar 10, 2021 · 0 comments · Fixed by #890 or #917
Assignees
@skliper
Labels
CFS-38 enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Mar 10, 2021

Is your feature request related to a problem? Please describe.
Hard coded copy block size:

osal/src/os/shared/src/osapi-file.c

Line 423 in ead5723

uint8 copyblock[512];

Describe the solution you'd like
Make a #define with clear documentation that it could be adjusted for page size or whatever, performance, etc.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC, OSAL code review
@skliper skliper added this to the 6.0.0 milestone Mar 10, 2021
@skliper skliper assigned skliper and unassigned skliper Mar 11, 2021
skliper added a commit to skliper/osal that referenced this issue Mar 11, 2021
@skliper
Fix nasa#875, Move copyblock size to define
cdddcee
@skliper skliper mentioned this issue Mar 11, 2021
Merged
astrogeco added a commit that referenced this issue Mar 17, 2021
@astrogeco
Merge pull request #890 from skliper/fix875-copyblock_size
e24723b 
Fix #875, Move copyblock size to define
@astrogeco astrogeco mentioned this issue Mar 17, 2021
Merged
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@yammajamma
Merge pull request nasa#875 from skliper/fix873-unsub-unsub
9712464 
Fix nasa#873, Add test for SB subscribe/unusubscribe/unsubscribe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
CFS-38 enhancement
Projects
None yet
Milestone
Caelum
2 participants
@skliper @astrogeco