Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error code for ESPIPE lseek failure (not OS_ERR_NOT_IMPLEMENTED) #867

Closed
skliper opened this issue Mar 10, 2021 · 0 comments · Fixed by #903 or #917
Closed

Better error code for ESPIPE lseek failure (not OS_ERR_NOT_IMPLEMENTED) #867

skliper opened this issue Mar 10, 2021 · 0 comments · Fixed by #903 or #917
Assignees
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Mar 10, 2021

Is your feature request related to a problem? Please describe.
OS_ERR_NOT_IMPLEMENTED error code used for ESPIPE lseek error:

if (errno == ESPIPE)
{
/*
* this means the user tried to seek on a pipe, socket,
* or other fifo-like handle that doesn't support seeking.
*
* Use a different error code to differentiate from an
* error involving a bad whence/offset
*/
retval = OS_ERR_NOT_IMPLEMENTED;

Describe the solution you'd like
Replace error code with something more appropriate

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC, OSAL code review

@skliper skliper added this to the 6.0.0 milestone Mar 10, 2021
jphickey added a commit to jphickey/osal that referenced this issue Mar 12, 2021
The ESPIPE errno means that seeking is not supported on the
given file handle.  Translate to the OS_ERR_OPERATION_NOT_SUPPORTED
error rather than not implemented as it better indicates the
actual condition.
jphickey added a commit to jphickey/osal that referenced this issue Mar 12, 2021
The ESPIPE errno means that seeking is not supported on the
given file handle.  Translate to the OS_ERR_OPERATION_NOT_SUPPORTED
error rather than not implemented as it better indicates the
actual condition.
astrogeco added a commit that referenced this issue Mar 22, 2021
Fix #867, better error translation for ESPIPE errno
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants