Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use compile time assert on address length check in bind #861

Closed
skliper opened this issue Mar 10, 2021 · 0 comments · Fixed by #908 or #917
Closed

Use compile time assert on address length check in bind #861

skliper opened this issue Mar 10, 2021 · 0 comments · Fixed by #908 or #917
Assignees
@jphickey
Labels
CFS-38 enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Mar 10, 2021

Is your feature request related to a problem? Please describe.
Known at compile time:

osal/src/os/portable/os-impl-bsd-sockets.c

Line 203 in ead5723

if (addrlen == 0 || addrlen > OS_SOCKADDR_MAX_LEN)

Describe the solution you'd like
Use CompileTimeAssert

Describe alternatives you've considered
What if sizeof(struct sockaddr_in6) is > OS_SOCKADDR_MAX_LEN but only AF_INET is used? Not really an error? Maybe only really known if OS_NETWORK_SUPPORTS_IPV6 is not defined?

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC, OSAL code review
@skliper skliper added this to the 6.0.0 milestone Mar 10, 2021
jphickey added a commit to jphickey/osal that referenced this issue Mar 15, 2021
@jphickey
Fix nasa#861, compile time assert for sockaddr size
87c9cf2 
OSAL provides an abstract buffer for socket addresses, independent
of the underlying implementation.  The size of this buffer is
configurable by the user via compile-time options.

This adds a CompileTimeAssert to confirm that the size of this
abstract buffer is large enough to store any of the enabled
address types. This also removes the need for runtime tests.
@jphickey jphickey mentioned this issue Mar 15, 2021
Merged
@astrogeco astrogeco mentioned this issue Mar 19, 2021
Merged
astrogeco added a commit that referenced this issue Mar 19, 2021
@astrogeco
Merge pull request #908 from jphickey/fix-861-sockaddr-size-check
03927ee 
Fix #861, compile time assert for sockaddr size
astrogeco added a commit to astrogeco/osal that referenced this issue Mar 22, 2021
@astrogeco
Merge pull request nasa#908 from jphickey/fix-861-sockaddr-size-check
a54f95f 
Fix nasa#861, compile time assert for sockaddr size
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@yammajamma
Merge pull request nasa#861 from nasa/integration-candidate
db82929 
Integration Candidate: 2020-09-02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
CFS-38 enhancement
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @skliper