Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assert for FD_SET_SIZE in relation to OSAL_set #855

Closed
skliper opened this issue Mar 10, 2021 · 0 comments · Fixed by #897 or #917
Closed

Add assert for FD_SET_SIZE in relation to OSAL_set #855

skliper opened this issue Mar 10, 2021 · 0 comments · Fixed by #897 or #917
Assignees
@jphickey
Labels
CFS-38 enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Mar 10, 2021

Is your feature request related to a problem? Please describe.
FD_SET has limits:

osal/src/os/portable/os-impl-bsd-select.c

Line 97 in ead5723

FD_SET(osfd, os_set);

Describe the solution you'd like
Should respect the FD_SET_SIZE limit (prefer compile time error)

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC, OSAL code review
@skliper skliper added this to the 6.0.0 milestone Mar 10, 2021
jphickey added a commit to jphickey/osal that referenced this issue Mar 12, 2021
@jphickey
Fix nasa#855, check against FD_SETSIZE in bsd-select
cd9393f 
The select() implementation utilizes its own set size limit
that should be checked.
@jphickey jphickey mentioned this issue Mar 12, 2021
Merged
jphickey added a commit to jphickey/osal that referenced this issue Mar 12, 2021
@jphickey
Fix nasa#855, check against FD_SETSIZE in bsd-select
447366f 
The select() implementation utilizes its own set size limit
that should be checked.
@astrogeco astrogeco mentioned this issue Mar 18, 2021
Merged
astrogeco added a commit to astrogeco/osal that referenced this issue Mar 19, 2021
@astrogeco
Merge pull request nasa#855 from 'jphickey/fix-855-fd-setsize`
40aa4cd 
Fix nasa#855, check against FD_SETSIZE in bsd-select

The select() implementation utilizes its own set size limit
that should be checked.
astrogeco added a commit to astrogeco/osal that referenced this issue Mar 19, 2021
@astrogeco
Merge pull request nasa#855 from 'jphickey/fix-855-fd-setsize`
cd7c3d1 
Fix nasa#855, check against FD_SETSIZE in bsd-select

The select() implementation utilizes its own set size limit
that should be checked.
astrogeco added a commit to astrogeco/cFS that referenced this issue Mar 19, 2021
@astrogeco
Add nasa/osal#855
02b1986
astrogeco added a commit to astrogeco/osal that referenced this issue Mar 22, 2021
@astrogeco
Merge pull request nasa#897 from 'jphickey/fix-855-fd-setsize`
db9b569 
Fix nasa#855, check against FD_SETSIZE in bsd-select

The select() implementation utilizes its own set size limit
that should be checked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
CFS-38 enhancement
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @skliper