Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in osapi.h #757

Closed
johnphamngc opened this issue Jan 13, 2021 · 0 comments · Fixed by #758 or #767
Closed

Typo in osapi.h #757

johnphamngc opened this issue Jan 13, 2021 · 0 comments · Fixed by #758 or #767
Labels
Milestone

Comments

@johnphamngc
Copy link

johnphamngc commented Jan 13, 2021

Describe the bug
Typo in osapi.h causes compilation failure when included into a c++ file

To Reproduce
Include osapi.h into a c++ file

Expected behavior
Successful compilation

Code snips

The following line is missing its corresponding extern "C" { and fails to build under C++:

osal/src/os/inc/osapi.h

Lines 97 to 99 in 89bd11a

#ifdef __cplusplus
}
#endif

Appears to be introduced in f0bd42e

System observed on:
Linux

Reporter Info
John N Pham, Northrop Grumman

@skliper skliper added this to the 6.0.0 milestone Jan 13, 2021
@skliper skliper added the bug label Jan 13, 2021
skliper added a commit to skliper/osal that referenced this issue Jan 13, 2021
skliper added a commit to skliper/osal that referenced this issue Jan 13, 2021
astrogeco added a commit that referenced this issue Jan 21, 2021
Fix #757, Read extern C in osapi.h to support C++ use
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants