Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate OS_fsBlocksFree and OS_fsBytesFree #718

Closed
jphickey opened this issue Dec 29, 2020 · 2 comments · Fixed by #759 or #767
Closed

Deprecate OS_fsBlocksFree and OS_fsBytesFree #718

jphickey opened this issue Dec 29, 2020 · 2 comments · Fixed by #759 or #767
Assignees
Milestone

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As noted in #573 these functions return the value directly, which does double duty as an error code and therefore is limited to being int32 - but this type is not big enough for large file systems.

Describe the solution you'd like
Deprecate these functions in favor of OS_FileSysStatVolume() added in PR #717, which returns the information as a OS_statvfs_t object containing all relevant information.

Additional context
References to these functions within OSAL tests need to be fixed/replaced, as well as references in CFE/apps. This is a follow-on/completion of the fix for #573 / PR #717. Deprecation has to be done separately because the new function needs to exist before the refs can be changed.

Requester Info
Joseph Hickey, Vantage Systems. Inc.

@skliper
Copy link
Contributor

skliper commented Jan 11, 2021

@astrogeco @jphickey any way we can get a PR in this week? Delaying code review a week for this isn't very palatable, and I'd like to tag/branch and then remove all deprecated code ASAP.

@skliper
Copy link
Contributor

skliper commented Jan 11, 2021

@ejtimmon - one last (so far) impact to apps from OSAL, see cfs_fm/fsw/src/fm_cmds.c

jphickey added a commit to jphickey/osal that referenced this issue Jan 14, 2021
Users should call OS_FileSysStatVolume() and read the respective
output members of the structure as indicated.
astrogeco added a commit that referenced this issue Jan 21, 2021
Fix #718, deprecate OS_fsBlocksFree and OS_fsBytesFree
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants