-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify config by inferring OSAL_SYSTEM_OSTYPE from OSAL_SYSTEM_BSPTYPE #432
Labels
Milestone
Comments
jphickey
added a commit
to jphickey/osal
that referenced
this issue
Apr 21, 2020
The OSAL_SYSTEM_BSPTYPE specification by itself is enough to build OSAL, as it implies a specific OS layer. However, if OSAL_SYSTEM_OSTYPE is explicitly specified, it is used, but will generate a warning if it is different than the OS layer implied by the BSP, as there could be reasons for doing this during development.
jphickey
added a commit
to jphickey/osal
that referenced
this issue
Apr 21, 2020
The OSAL_SYSTEM_BSPTYPE specification by itself is enough to build OSAL, as it implies a specific OS layer. However, if OSAL_SYSTEM_OSTYPE is explicitly specified, it is used, but will generate a warning if it is different than the OS layer implied by the BSP, as there could be reasons for doing this during development.
This was referenced Apr 21, 2020
CCB 20200422 - Open new PR for 2f67435 and fast track |
jphickey
added a commit
to jphickey/osal
that referenced
this issue
Apr 22, 2020
The OSAL_SYSTEM_BSPTYPE specification by itself is enough to build OSAL, as it implies a specific OS layer. However, if OSAL_SYSTEM_OSTYPE is explicitly specified, it is used, but will generate a warning if it is different than the OS layer implied by the BSP, as there could be reasons for doing this during development.
astrogeco
added a commit
that referenced
this issue
Apr 24, 2020
Fix #432, Infer OSAL_SYSTEM_OSTYPE from OSAL_SYSTEM_BSPTYPE
astrogeco
pushed a commit
that referenced
this issue
May 1, 2020
The OSAL_SYSTEM_BSPTYPE specification by itself is enough to build OSAL, as it implies a specific OS layer. However, if OSAL_SYSTEM_OSTYPE is explicitly specified, it is used, but will generate a warning if it is different than the OS layer implied by the BSP, as there could be reasons for doing this during development.
jphickey
pushed a commit
to jphickey/osal
that referenced
this issue
Aug 10, 2022
Fix nasa#425, update cppcheck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Currently the build requires that the user specify both OSAL_SYSTEM_BSPTYPE and OSAL_SYSTEM_OSTYPE. This is redundant because each BSP only works with a specific OS.
Describe the solution you'd like
The user should be allowed to specify only OSAL_SYSTEM_BSPTYPE, and the correct OS layer can be inferred automatically.
Describe alternatives you've considered
Continue as is, which increases user config burden and risk of misconfiguration
Additional context
see also nasa/cFE#632
Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: