Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS_FileSysAddFixedMap missing functional test #379

Closed
skliper opened this issue Mar 23, 2020 · 4 comments · Fixed by #489 or #563
Closed

OS_FileSysAddFixedMap missing functional test #379

skliper opened this issue Mar 23, 2020 · 4 comments · Fixed by #489 or #563
Labels
enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Mar 23, 2020

Is your feature request related to a problem? Please describe.
Missing functional test for OS_FileSysAddFixedMap

Describe the solution you'd like
Add test

Describe alternatives you've considered
None

Additional context
Certification issue

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 5.1.0 milestone Mar 23, 2020
@CDKnightNASA CDKnightNASA added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Mar 27, 2020
@yammajamma
Copy link
Contributor

I can take this one.

@jphickey
Copy link
Contributor

FYI - as part of my upcoming changes (#449 #460), the unit tests will be using this function to set up for a BSP-agnostic file map.

I'm not sure if there is anything more that can be done with them beyond this, because any test would require going around the OSAL abstraction in a platform-dependent manner. Furthermore, if they didn't work right, all the tests following that depend on the map will fail.

So in other words I think its covered already

@skliper skliper assigned yammajamma and unassigned yammajamma May 14, 2020
@skliper
Copy link
Contributor Author

skliper commented May 27, 2020

@yammajamma - could you review the unit test updates in #461 and ensure it meets the functional test standards (covers everything we've discussed a functional test needs to cover)? If so we can close this. If not let's add whatever is missing and/or create a unique test.

@yammajamma
Copy link
Contributor

@skliper Yes, I can take a look at that, thanks.

yammajamma added a commit to yammajamma/osal that referenced this issue Jun 3, 2020
@yammajamma
Fix nasa#379, Add FileSysAddFixedMap functional API test
54bc184
@yammajamma yammajamma mentioned this issue Jun 3, 2020
Merged
@skliper skliper modified the milestones: 5.1.0, 5.2.0 Jul 30, 2020
yammajamma added a commit to yammajamma/osal that referenced this issue Aug 10, 2020
@yammajamma
Fix nasa#379, Add FileSysAddFixedMap functional API test
5cf325b
astrogeco pushed a commit that referenced this issue Aug 14, 2020
@yammajamma
Fix #379, Add FileSysAddFixedMap functional API test (#489)
34e0978
@yammajamma yammajamma mentioned this issue Aug 18, 2020
Merged
@skliper skliper modified the milestones: 5.2.0, 6.0.0 Sep 1, 2020
@astrogeco astrogeco modified the milestones: 6.0.0, v5.1.0 Sep 21, 2020
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
Fix nasa#379: Remove test results from FSW path
224b7c0
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
20191106/13: Merge nasa#387 nasa#390 nasa#391 nasa#393 nasa#395 nasa#400
9aedaab 


Fixes nasa#379, Fixes nasa#380, Fixes nasa#383, Fixes nasa#384,
Fixes nasa#385, Fixes nasa#392
Code reviewed and approved at 20191106 and 20191113 CB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Milestone
Bootes
5 participants
@jphickey @CDKnightNASA @skliper @astrogeco @yammajamma