Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSAL coverage test should be part of normal build #362

Closed
jphickey opened this issue Feb 26, 2020 · 0 comments · Fixed by #404
Closed

OSAL coverage test should be part of normal build #362

jphickey opened this issue Feb 26, 2020 · 0 comments · Fixed by #404
Assignees
@jphickey
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently the src/unit-test-coverage directory is an entirely separate build which needs to be invoked separately by the user.

As per CFE request nasa/cFE#386 it is desired to integrate the OSAL coverage tests as part of the normal unit test builds, so these do not need to be built separately.

Describe the solution you'd like
The tentatively agreed-upon approach is to build all coverage targets by default, and use the target BSP to run them.

Additional context
The side effect is that this may build coverage targets which are not relevant to the deployed platform (e.g. building and running a VxWorks coverage test for a platform that does not use VxWorks).

Requester Info
Joseph Hickey, Vantage Systems, Inc.
jphickey added a commit to jphickey/osal that referenced this issue Feb 26, 2020
@jphickey
Fix nasa#362, integrate coverage with UT build
6ea8b94 
Build the full suite of OSAL coverage tests as part of
the normal build when ENABLE_UNIT_TESTS is true.

This will use the same target OSAL BSP to execute the tests
as is used for the FSW.
@skliper skliper added this to the 5.1.0 milestone Mar 3, 2020
jphickey added a commit to jphickey/osal that referenced this issue Mar 10, 2020
@jphickey
Fix nasa#362, integrate coverage with UT build
c8ed89e 
Build the full suite of OSAL coverage tests as part of
the normal build when ENABLE_UNIT_TESTS is true.

This will use the same target OSAL BSP to execute the tests
as is used for the FSW.
@jphickey jphickey mentioned this issue Mar 24, 2020
Closed
@skliper skliper mentioned this issue Mar 26, 2020
Merged
jphickey added a commit to jphickey/osal that referenced this issue Apr 2, 2020
@jphickey
Fix nasa#362, integrate coverage with UT build
0c0c06c 
Build the full suite of OSAL coverage tests as part of
the normal build when ENABLE_UNIT_TESTS is true.

This will use the same target OSAL BSP to execute the tests
as is used for the FSW.
@jphickey jphickey mentioned this issue Apr 2, 2020
Merged
@jphickey jphickey linked a pull request Apr 3, 2020 that will close this issue
Fix #261, #312, and #362, OSAL build cleanup (multiple issues) #404
Merged
astrogeco added a commit that referenced this issue Apr 16, 2020
@astrogeco
Merge pull request #404 from jphickey/fix-312-261-362-build-cleanup
38bb192 
Fix #261, #312, and #362, OSAL build cleanup (multiple issues)
@astrogeco astrogeco mentioned this issue Apr 16, 2020
Merged
@skliper skliper mentioned this issue Apr 23, 2020
Closed
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
CCB 20191023/30: Merge nasa#362 nasa#375 nasa#376 nasa#382
e9f7382 
Fixes nasa#361, nasa#373, nasa#374, nasa#381
Code reviewed and approved at 20191023 and 30 CCBs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
None yet
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Fix #261, #312, and #362, OSAL build cleanup (multiple issues) jphickey/osal
2 participants
@jphickey @skliper