Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unit test backwards compatibility in osapi-filesys functions #259

Closed
skliper opened this issue Sep 30, 2019 · 1 comment · Fixed by #387 or #408
Closed

Remove unit test backwards compatibility in osapi-filesys functions #259

skliper opened this issue Sep 30, 2019 · 1 comment · Fixed by #387 or #408
Assignees
@dmknutsen
Labels
enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

Flight code should have the right implementation, and unit test code should be fixed to match. Current comments indicate the flight code is less than optimal to match unit test code.

Specifically: OS_FS_ERROR vs OS_ERR_NAME_NOT_FOUND returns.
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 236. Created by jhageman on 2019-08-19T17:08:32, last modified: 2019-08-19T17:08:32

@skliper skliper added this to the osal-5.0.1 milestone Sep 30, 2019
@skliper skliper self-assigned this Sep 30, 2019
@skliper skliper modified the milestones: osal-5.0.1, osal-5.1.0 Sep 30, 2019
@skliper skliper removed their assignment Sep 30, 2019
dmknutsen added a commit to dmknutsen/osal that referenced this issue Mar 25, 2020
@dmknutsen
Fixes nasa#259, updated osapi-filesys.c + ut_osfilesys_diskio_test to…
2a5e9ca 
… use desired return values
@dmknutsen dmknutsen mentioned this issue Mar 25, 2020
Merged
astrogeco added a commit that referenced this issue Apr 6, 2020
@astrogeco
Merge pull request #387 from dmknutsen/issue_259
e52f37c 
Fix #259, updated osapi-filesys.c + ut_osfilesys_diskio_tes.ct to use…
@astrogeco astrogeco mentioned this issue Apr 9, 2020
Merged
@astrogeco astrogeco added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Sep 22, 2020
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@dmknutsen
Fix nasa#259, Update tone leap variable
db3a035
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
Merge pull request nasa#453 from dmknutsen/issue_259
54c7b51 
Fix nasa#259, Update tone leap variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmknutsen dmknutsen

Labels
enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Milestone
Bootes
3 participants
@skliper @dmknutsen @astrogeco