Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mqueue test program #229

Closed
skliper opened this issue Sep 30, 2019 · 3 comments · Fixed by #695 or #767
Closed

mqueue test program #229

skliper opened this issue Sep 30, 2019 · 3 comments · Fixed by #695 or #767
Assignees
Labels
enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

OSAL should include a simple mqueue test program to validate that the user has the correct settings and permissions to create/open/close/delete mqueues. Often users stumble on mqueue configuration and it is more difficult to diagnose when it's wrapped in the entirety of OSAL/cFS.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 206. Created by cdknight on 2018-11-16T19:04:20, last modified: 2019-08-14T14:11:46

@skliper skliper self-assigned this Sep 30, 2019
@skliper skliper assigned CDKnightNASA and unassigned skliper Sep 30, 2019
@jphickey
Copy link
Contributor

Rather than making a whole new test program, there is already a "queue-timeout-test" test program that does much of this.

Right now this test program only focuses on calling OS_QueueCreate() followed by OS_QueueGet() and getting the timeout response. But it shouldn't be too hard to just add another test case to this, to actually call OS_QueuePut() to send some test data into the queue and validate it on the other side.

Furthermore, the ut_oscore_queue_test does a much more extensive test of the OS_QueuePut/OS_QueueGet functions, but it is a bit convoluted and doesn't use the same framework.

@skliper
Copy link
Contributor Author

skliper commented Oct 18, 2019

Preference is to add test or add to existing test (queue-timeout-test) using the utassert framework. Either approach is fine (if you want to keep queue-timeout-test specific to timeouts and add a test for general queue behavior, or if you want to generalize the existing test to cover more functionality).

Expending resources on the "unit-tests" that use the alternate framework is discouraged. Eventually the "scenarios" covered by these tests should all be covered by the utassert tests.

@skliper skliper added this to the 5.1.0 milestone Oct 22, 2019
@skliper skliper added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Apr 10, 2020
@skliper skliper modified the milestones: 5.1.0, 5.2.0 Jun 5, 2020
@skliper skliper modified the milestones: 5.2.0, 6.0.0 Sep 1, 2020
zanzaben added a commit to zanzaben/osal that referenced this issue Dec 17, 2020
zanzaben added a commit to zanzaben/osal that referenced this issue Dec 17, 2020
Will squash this commit after review
zanzaben added a commit to zanzaben/osal that referenced this issue Jan 4, 2021
zanzaben added a commit to zanzaben/osal that referenced this issue Jan 13, 2021
zanzaben added a commit to zanzaben/osal that referenced this issue Jan 22, 2021
astrogeco added a commit that referenced this issue Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants