Fix #1110, Modify unreachable branch in OS_ObjectIdAllocateNew #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chillfig
approved these changes
Feb 23, 2023
dzbaker
added
the
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Feb 27, 2023
*Combines:* osal v6.0.0-rc4+dev199 tblCRCTool v1.3.0-rc4+dev28 **Includes:** *osal* - nasa/osal#1327 *tblCRCTool* - nasa/tblCRCTool#77 Co-authored by: Avi Weiss <[email protected]>
This was referenced Feb 27, 2023
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Feb 27, 2023
*Combines:* osal v6.0.0-rc4+dev199 tblCRCTool v1.3.0-rc4+dev28 **Includes:** *osal* - nasa/osal#1327 *tblCRCTool* - nasa/tblCRCTool#77 Co-authored by: Avi Weiss <[email protected]>
thnkslprpt
deleted the
fix-1110-modify-unreachable-branch-in-OS_ObjectIdAllocateNew
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Fixes #1110
Changes 2 mutually exclusive, consecutive
ifstatements to anif/elseblock.I believe this is the most parsimonious fix to this issue.
Testing performed
GitHub CI Unit Tests all passing successfully.
Expected behavior changes
No change to behavior.
Contributor Info
Avi @thnkslprpt