Unreachable error branch in OS_ObjectIdAllocateNew

[skliper]

Is your feature request related to a problem? Please describe.
Code checks for error and if so returns, then checks for not error (always true):

osal/src/os/shared/src/osapi-idmap.c

Lines 1236 to 1245 in cb95655

	if (return_code != OS_SUCCESS)
	{
	OS_ObjectIdTransactionCancel(token);
	return return_code;
	}
	if (return_code == OS_SUCCESS)
	{
	return_code = OS_NotifyEvent(OS_EVENT_RESOURCE_ALLOCATED, token->obj_id, NULL);
	}

Describe the solution you'd like
Could be an else, or just remove check... (or test for == OS_SUCCESS and the else could be the error case)

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC