Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Workflow check catching empty function #1305

Closed
thnkslprpt opened this issue Oct 7, 2022 · 0 comments · Fixed by #1306
Closed

CI Workflow check catching empty function #1305

thnkslprpt opened this issue Oct 7, 2022 · 0 comments · Fixed by #1306
Labels
draco-rc4
Milestone
Draco

Comments

@thnkslprpt
Copy link
Contributor 

    > > @thnkslprpt Can you fix the issue pointed out in the format check workflow

Can I still address these now that the issue is closed and PR merged?

That's a good point, you may need to open a new PR to address it. You could either reopen the original issue or create a new one specific to the format check error. Let me know if you'd like me to create an issue for you. Thanks again!

Originally posted by @dzbaker in #1294 (comment)
thnkslprpt added a commit to thnkslprpt/osal that referenced this issue Oct 7, 2022
@thnkslprpt
Fix nasa#1305, Stop empty function catching CI workflow format checks
6dcae06
@thnkslprpt thnkslprpt mentioned this issue Oct 7, 2022
Merged
2 tasks
@dzbaker dzbaker linked a pull request Oct 13, 2022 that will close this issue
Fix #1305, Stop empty function catching CI workflow format checks #1306
Merged
2 tasks
dzbaker added a commit that referenced this issue Oct 17, 2022
@dzbaker
Merge pull request #1306 from thnkslprpt/fix-1305-workflow-check-failure
1800a6a 
Fix #1305, Stop empty function catching CI workflow format checks
@dzbaker dzbaker mentioned this issue Oct 17, 2022
Merged
2 tasks
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
draco-rc4
Projects
None yet
Milestone
Draco
Development

Successfully merging a pull request may close this issue.

Fix #1305, Stop empty function catching CI workflow format checks thnkslprpt/osal
2 participants
@thnkslprpt @dmknutsen