Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant condition checks in UT #1254

Closed
skliper opened this issue May 16, 2022 · 0 comments · Fixed by #1255 or #1260
Closed

Redundant condition checks in UT #1254

skliper opened this issue May 16, 2022 · 0 comments · Fixed by #1255 or #1260
Assignees
@skliper
Labels
draco-rc2 unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Draco

Comments

@skliper
Copy link
Contributor

skliper commented May 16, 2022

Is your feature request related to a problem? Please describe.
Redundant conditions (unsigned int check >= 0) observed in UT

Describe the solution you'd like
Fix

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label May 16, 2022
@skliper skliper added this to the Draco milestone May 16, 2022
@skliper skliper self-assigned this May 16, 2022
skliper added a commit to skliper/osal that referenced this issue May 16, 2022
@skliper
Fix nasa#1254, Remove redundant checks in UT
2a6d659
skliper added a commit to skliper/osal that referenced this issue May 16, 2022
@skliper
Fix nasa#1254, Remove redundant checks in UT
71d7343
skliper added a commit to skliper/osal that referenced this issue May 17, 2022
@skliper
Fix nasa#1254, Remove redundant checks in UT
3e6c9fe
skliper added a commit to skliper/osal that referenced this issue May 17, 2022
@skliper
Fix nasa#1254, Remove redundant checks in UT
72dea97
skliper added a commit to skliper/osal that referenced this issue May 18, 2022
@skliper
Fix nasa#1254, Remove redundant checks in UT
bc6dd70
@skliper skliper mentioned this issue May 18, 2022
Merged
2 tasks
astrogeco added a commit that referenced this issue May 31, 2022
@astrogeco
Merge pull request #1255 from skliper/fix1253-ut_uninit_vars
4f2c16e 
Fix #1253 #1254, Resolve static analysis warnings
@astrogeco astrogeco mentioned this issue May 31, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
draco-rc2 unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Milestone
Draco
1 participant
@skliper