Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse CodeQL, Format Checker, and Static Analysis Workflows #1188

Closed
ArielSAdamsNASA opened this issue Oct 25, 2021 · 0 comments · Fixed by #1190 or #1212
Closed

Reuse CodeQL, Format Checker, and Static Analysis Workflows #1188

ArielSAdamsNASA opened this issue Oct 25, 2021 · 0 comments · Fixed by #1190 or #1212

Comments

@ArielSAdamsNASA
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When needing to change workflows, one must create an issue and PR for each submodule. This feature would reduce duplication.

Describe the solution you'd like
To reuse workflows, the workflow simply uses uses and the full path of the workflow. The cFS workflows, or targeted workflows, must include workflow_call and runs-on as seen below.

on:
  push:
  pull_request:
  workflow_call:
    inputs:
      runs-on: 
        description: Platform to execute on
        type: string
        default: ubuntu-latest

Describe alternatives you've considered
Keep it as is.

Additional context
Tested in forked cFS: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1381659167
Tested in forked OSAL: https://github.com/ArielSAdamsNASA/osal/actions/runs/1381486439

Requester Info
Ariel Adams, ASRC Federal

@ArielSAdamsNASA ArielSAdamsNASA self-assigned this Oct 25, 2021
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/osal that referenced this issue Oct 27, 2021
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/osal that referenced this issue Oct 27, 2021
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/osal that referenced this issue Oct 27, 2021
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/osal that referenced this issue Oct 27, 2021
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/osal that referenced this issue Oct 27, 2021
astrogeco added a commit that referenced this issue Jan 20, 2022
Fix #1188, Reuse CodeQL, Static Analysis, Format Check
@skliper skliper added this to the Draco milestone Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment