Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSAL loader test hard fails if size exceeded #1151

Closed
skliper opened this issue Sep 15, 2021 · 0 comments · Fixed by #1152 or #1158
Closed

OSAL loader test hard fails if size exceeded #1151

skliper opened this issue Sep 15, 2021 · 0 comments · Fixed by #1152 or #1158
Assignees
@skliper
Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Sep 15, 2021

Is your feature request related to a problem? Please describe.
Hard failure if UT_SYMTABLE_SIZE_LIMIT not big enough:

osal/src/unit-tests/osloader-test/ut_osloader_symtable_test.c

Lines 199 to 202 in 2a2defb

if (UT_NOMINAL_OR_NOTIMPL(OS_SymbolTableDump(UT_OS_GENERIC_MODULE_DIR "SymbolReal.dat", UT_SYMTABLE_SIZE_LIMIT)))
{
UT_RETVAL(OS_SymbolTableDump(UT_OS_GENERIC_MODULE_DIR "SymbolZero.dat", 0), OS_ERR_OUTPUT_TOO_LARGE);
}

Describe the solution you'd like
MIR if symbol table isn't large enough

Describe alternatives you've considered
Could consolidate this and test/symbol-api-test

Additional context
Similar issue as fixed in #1149

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Sep 15, 2021
@skliper skliper added this to the 6.0.0 milestone Sep 15, 2021
@skliper skliper self-assigned this Sep 15, 2021
skliper added a commit to skliper/osal that referenced this issue Sep 15, 2021
@skliper
Fix nasa#1151, MIR symbol too long or table to long for osloader test
6fd967c
@skliper skliper mentioned this issue Sep 15, 2021
Merged
astrogeco added a commit that referenced this issue Sep 21, 2021
@astrogeco
Merge pull request #1152 from skliper/fix1151-osloader_ut
99c5c6e 
Fix #1151, MIR symbol too long or table to long for osloader test
@astrogeco astrogeco mentioned this issue Sep 21, 2021
Merged
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#1151 from jphickey/fix-978-entrypt
414036e 
Fix nasa#978, put task parameters into task record
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Milestone
Caelum
1 participant
@skliper