Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSAL loader unit test builds hardcoded 32 modules, test fails if more modules are supported #1150

Closed
skliper opened this issue Sep 15, 2021 · 0 comments · Fixed by #1265 or #1268
Closed

OSAL loader unit test builds hardcoded 32 modules, test fails if more modules are supported #1150

skliper opened this issue Sep 15, 2021 · 0 comments · Fixed by #1265 or #1268
Assignees
@dzbaker
Labels
draco-rc3 unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Draco

Comments

@skliper
Copy link
Contributor

skliper commented Sep 15, 2021

Is your feature request related to a problem? Please describe.
Test failure based on hard 32 setting in CMakeList.txt in the osal tree larger OS_MAX_MODULES is configured:

osal/src/unit-tests/osloader-test/CMakeLists.txt

Line 13 in 2a2defb

set(MOD 32)

Describe the solution you'd like
Possibly relate to OSAL_CONFIG_MAX_MODULES (+1):

osal/default_config.cmake

Line 244 in 2a2defb

set(OSAL_CONFIG_MAX_MODULES 20

Otherwise at minimum make it configurable, and if so test should TSF with a useful message like increase XXX to match YYY.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Sep 15, 2021
skliper added a commit to skliper/osal that referenced this issue Sep 15, 2021
@skliper
Fix nasa#1150, MIR symbol too long or table to long for osloader test
fa52c5f
@dzbaker dzbaker mentioned this issue Jun 29, 2022
Merged
2 tasks
@dmknutsen dmknutsen added this to the Draco milestone Jul 5, 2022
dzbaker added a commit to dzbaker/osal that referenced this issue Jul 6, 2022
@dzbaker
Fix nasa#1150, Set OSAL Loader unit test number of modules to OSAL_CO…
02aa1d2 
…NFIG_MAX_MODULES.
dzbaker added a commit that referenced this issue Jul 6, 2022
@dzbaker
Merge pull request #1265 from dzbaker/fix-1150-osal-loader-ut-hardcod…
010303b 
…ed-modules

Fix #1150, Set OSAL Loader unit test number of modules to OSAL_CONFIG_MAX_MODULES
@dzbaker dzbaker mentioned this issue Jul 7, 2022
Merged
2 tasks
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#1150 from nasa/integration-candidate
6b9c267 
cFE  Integration candidate: 2021-02-02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dzbaker dzbaker

Labels
draco-rc3 unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Milestone
Draco
3 participants
@dzbaker @skliper @dmknutsen