Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbol API test uses old OS_INCLUDE_MODULE_LOADER, ends up skipping tests #1148

Closed
skliper opened this issue Sep 13, 2021 · 0 comments · Fixed by #1149 or #1158
Closed

Symbol API test uses old OS_INCLUDE_MODULE_LOADER, ends up skipping tests #1148

skliper opened this issue Sep 13, 2021 · 0 comments · Fixed by #1149 or #1158
Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Sep 13, 2021

Is your feature request related to a problem? Please describe.
Possibly missed in #427 conversion to source selection, TestSymbolApi depends on the old define which means it hasn't been getting tested for a while:

osal/src/tests/symbol-api-test/symbol-api-test.c

Line 35 in 2a2defb

#ifdef OS_INCLUDE_MODULE_LOADER

Describe the solution you'd like
Convert to check for OS_ERR_NOT_IMPLEMENTED (applies to OS_SymbolLookup, OS_SymbolTableDump already has it)

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Sep 13, 2021
skliper added a commit to skliper/osal that referenced this issue Sep 15, 2021
@skliper
Fix nasa#1148, Enable symbol api test and MIR dump too large
89f5bb9
skliper added a commit to skliper/osal that referenced this issue Sep 15, 2021
@skliper
Fix nasa#1148, Enable symbol api test and MIR dump too large
0531bca
@skliper skliper mentioned this issue Sep 15, 2021
Merged
skliper added a commit to skliper/osal that referenced this issue Sep 15, 2021
@skliper
Fix nasa#1148, MIR symbol name too long in symbol-api-test
0f5454d
astrogeco added a commit that referenced this issue Sep 21, 2021
@astrogeco
Merge pull request #1149 from skliper/fix1148-symbol_test
94e6e35 
Fix #1148, Enable symbol api test and MIR dump too large
@astrogeco astrogeco mentioned this issue Sep 21, 2021
Merged
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#1148 from jphickey/fix-139-filewrite-background
37df32d 
Fix nasa#139, Do file writes in background
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Milestone
Caelum
1 participant
@skliper