Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extern from function prototypes in stub generator script #1139

Closed
skliper opened this issue Aug 30, 2021 · 0 comments · Fixed by #1191
Closed

Remove extern from function prototypes in stub generator script #1139

skliper opened this issue Aug 30, 2021 · 0 comments · Fixed by #1191
Labels
draco-rc1 good first issue Good for newcomers unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Draco

Comments

@skliper
Copy link
Contributor

skliper commented Aug 30, 2021

Is your feature request related to a problem? Please describe.
Function prototype extern prefix has no effect, from generator script:

osal/ut_assert/scripts/generate_stubs.pl

Line 330 in 2cd118e

print OUT "extern void ".$handler_func->{$funcname}."($args);\n";

Describe the solution you'd like
Remove.

Describe alternatives you've considered
None

Additional context
nasa/cFE#1319

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added good first issue Good for newcomers unit-test Tickets related to the OSAL unit testing (functional and/or coverage) labels Aug 30, 2021
@Shefali199 Shefali199 mentioned this issue Oct 9, 2021
Merged
astrogeco added a commit to astrogeco/osal that referenced this issue Nov 3, 2021
@astrogeco
Merge pull request nasa#1180 from Shefali321/contribution-branch
56ad768 
Fix nasa#1139, Remove extern in stub prototypes
@astrogeco astrogeco mentioned this issue Nov 3, 2021
Merged
@skliper skliper added this to the Draco milestone Mar 25, 2022
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#1139 from nasa/6.8.x
4f76f5f 
Fix nasa#1070 for main branch (merge of 6.8.x after bookkeeping)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
draco-rc1 good first issue Good for newcomers unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Milestone
Draco
Development

Successfully merging a pull request may close this issue.

osal Integration candidate: Caelum+dev1 astrogeco/osal
1 participant
@skliper