Unreachable branch on unknown fstype in OS_FileSys_Initialize

[skliper]

Is your feature request related to a problem? Please describe.
filesys->fstype == OS_FILESYS_TYPE_UNKNOWN is always true due to memset of filesys to zero in OS_OBJECT_INIT call. Nothing else can logically set it otherwise or reason to not set if the other conditions are true.

osal/src/os/shared/src/osapi-filesys.c

Lines 176 to 188 in cb95655

	/*
	* Determine basic type of filesystem, if not already known
	*
	* if either an address was supplied, or if the volume name
	* contains the string "RAM" then it is a RAM disk. Otherwise
	* leave the type as UNKNOWN and let the implementation decide.
	*/
	if (filesys->fstype == OS_FILESYS_TYPE_UNKNOWN &&
	(filesys->address != NULL || strncmp(filesys->volume_name, OS_FILESYS_RAMDISK_VOLNAME_PREFIX,
	sizeof(OS_FILESYS_RAMDISK_VOLNAME_PREFIX) - 1) == 0))
	{
	filesys->fstype = OS_FILESYS_TYPE_VOLATILE_DISK;
	}

Describe the solution you'd like
Remove dead branch.

Describe alternatives you've considered
Clear justification for leaving in.

Additional context
None.

Requester Info
Jacob Hageman - NASA/GSFC

[jphickey]

I concur on removing the conditional and assuming it is always OS_FILESYS_TYPE_VOLATILE_DISK in the current implementation.

This helper function is only used as part of OS_initfs and OS_mkfs and both of these public APIs are only intended to set up RAM disks. Non-volatile storage now uses a separate registration such as OS_FileSysAddFixedMap(). I think originally this code was also used for translating entries in the volume table, but that is no longer the case.