Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test runs out of Code QL Workflow #1099

Open
astrogeco opened this issue Jul 7, 2021 · 0 comments
Open

Move test runs out of Code QL Workflow #1099

astrogeco opened this issue Jul 7, 2021 · 0 comments

Comments

@astrogeco
Copy link
Contributor

Is your feature request related to a problem? Please describe.
codeql-cfe-build.yml runs the osal unit tests with a bundle-level build context (see line 106 below). Tests should be in their own workflow.

CodeQL-Coding-Standard-Build:
needs: check-for-duplicates
if: ${{ needs.check-for-duplicates.outputs.should_skip != 'true' }}
runs-on: ubuntu-18.04
timeout-minutes: 15
steps:
- name: Checkout bundle
uses: actions/checkout@v2
with:
repository: nasa/cFS
submodules: true
- name: Checkout submodule
uses: actions/checkout@v2
with:
path: osal
- name: Check versions
run: git submodule
- name: Initialize CodeQL
uses: github/codeql-action/init@v1
with:
languages: c
config-file: nasa/cFS/.github/codeql/codeql-coding-standard.yml@main
- name: Set up for build
run: |
cp ./cfe/cmake/Makefile.sample Makefile
cp -r ./cfe/cmake/sample_defs sample_defs
make prep
- name: Build
run: make -j native/default_cpu1/osal/
- name: Run tests
run: (cd build/native/default_cpu1/osal && make test)
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v1

Describe the solution you'd like
Create new workflow for building and testing osal with a cFS bundle context.

Describe alternatives you've considered
Move bundle test to the "local_unit_test"

@astrogeco astrogeco added continuous-integration CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jul 7, 2021
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant