Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time conductor refactor #7818

Draft
wants to merge 47 commits into
base: master
Choose a base branch
from
Draft

Time conductor refactor #7818

wants to merge 47 commits into from

Conversation

davetsay
Copy link
Contributor

Closes #7666
Closes #7665

recreation of #7774, which was closed inadvertently due to branch hijinks

Describe your changes:

  • use Vue reactivity and composables for time conductor Vue components
    • Should all composables be wrapped into useTimeContext?
  • Add back single Input functionality for non-utc timesystems
  • Separate Date Time functionality retained by adding a getDelimiter function to a time system's timeFormatter
    • Need to do something about milliseconds (precision) and zone designation
  • Copy and Paste from Date or Time input copies and pastes the entire formatted dateTime string
  • Pop up options shouldn't take effect unless form is submitted
  • Move History out of pop up form
  • Add back limits
  • Add back Time System validity (clock/mode sync)
  • unit/e2e tests

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

fix listener in useTimeSystem
documentation update to useTimeBounds
many things broken
will need refactor to account for independent time conductor
reactivity fixes to composables
Comment on lines +183 to +185
independentTCEnabled() {
this.handleIndependentTimeConductorChange();
},

Check warning

Code scanning / CodeQL

Duplicate property Warning

This property is duplicated
in a later property
.
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 40.11976% with 200 lines in your changes missing coverage. Please review.

Project coverage is 50.18%. Comparing base (21a4335) to head (140184e).
Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
...Conductor/independent/IndependentTimeConductor.vue 0.00% 90 Missing ⚠️
src/plugins/timeConductor/DateTimePopupFixed.vue 17.74% 51 Missing ⚠️
src/plugins/timeConductor/TimePopupFixed.vue 0.00% 25 Missing ⚠️
src/plugins/timeConductor/TimePopupRealtime.vue 33.33% 6 Missing ⚠️
src/plugins/timeConductor/ConductorComponent.vue 82.75% 5 Missing ⚠️
src/plugins/timeConductor/useTimeSystem.js 73.68% 5 Missing ⚠️
...gins/timeConductor/independent/IndependentMode.vue 0.00% 4 Missing ⚠️
src/plugins/timeConductor/useClock.js 80.95% 4 Missing ⚠️
...ins/timeConductor/independent/IndependentClock.vue 0.00% 3 Missing ⚠️
src/api/time/IndependentTimeContext.js 60.00% 2 Missing ⚠️
... and 5 more

❗ There is a different number of reports uploaded between BASE (21a4335) and HEAD (140184e). Click for more details.

HEAD has 121 uploads less than BASE
Flag BASE (21a4335) HEAD (140184e)
unit 55 1
e2e-ci 3 0
e2e-full 65 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7818      +/-   ##
==========================================
- Coverage   56.14%   50.18%   -5.96%     
==========================================
  Files         674      679       +5     
  Lines       27283    27233      -50     
  Branches     2669     2647      -22     
==========================================
- Hits        15317    13667    -1650     
- Misses      11629    13240    +1611     
+ Partials      337      326      -11     
Flag Coverage Δ
e2e-ci ?
e2e-full 23.84% <77.77%> (-31.29%) ⬇️
unit 49.30% <40.11%> (-0.24%) ⬇️
Files with missing lines Coverage Δ
src/api/time/TimeContext.js 90.47% <ø> (ø)
src/plugins/timeConductor/ConductorClock.vue 37.50% <100.00%> (+16.07%) ⬆️
src/plugins/timeConductor/ConductorHistory.vue 49.54% <ø> (-1.37%) ⬇️
src/plugins/timeConductor/ConductorInputsFixed.vue 80.00% <100.00%> (ø)
.../plugins/timeConductor/ConductorInputsRealtime.vue 87.50% <100.00%> (+12.15%) ⬆️
src/plugins/timeConductor/ConductorMode.vue 100.00% <100.00%> (ø)
src/plugins/timeConductor/ConductorPopUp.vue 50.00% <100.00%> (-5.82%) ⬇️
src/plugins/timeConductor/ConductorTimeSystem.vue 32.43% <ø> (-1.78%) ⬇️
src/plugins/timeConductor/DatePicker.vue 57.69% <ø> (ø)
src/plugins/timeConductor/useTimeContext.js 100.00% <100.00%> (ø)
... and 16 more

... and 179 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21a4335...140184e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant