Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package.json): consistent props #7768

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

evenstensberg
Copy link
Contributor

@evenstensberg evenstensberg commented Jul 2, 2024

Describe your changes:

package.json in e2e and root metadata should be identical.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.64%. Comparing base (92e5cba) to head (80c5040).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7768      +/-   ##
==========================================
- Coverage   56.66%   56.64%   -0.02%     
==========================================
  Files         673      673              
  Lines       27177    27177              
  Branches     2636     2636              
==========================================
- Hits        15399    15394       -5     
- Misses      11447    11452       +5     
  Partials      331      331              
Flag Coverage Δ
e2e-full 23.57% <ø> (ø)
e2e-stable 60.61% <ø> (-0.03%) ⬇️
unit 49.25% <ø> (+0.01%) ⬆️

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e5cba...80c5040. Read the comment docs.

@ozyx ozyx added the source:community Community contribution or request label Jul 2, 2024
@evenstensberg
Copy link
Contributor Author

@ozyx lmk if there's anything I need to do before it is mergeable :)

@ozyx
Copy link
Contributor

ozyx commented Jul 10, 2024

@ozyx lmk if there's anything I need to do before it is mergeable :)

Thanks @evenstensberg ! Really appreciate your patience with us. I'll have a look this afternoon. Cheers

@ozyx ozyx self-requested a review July 10, 2024 20:42
@evenstensberg
Copy link
Contributor Author

🌟

Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change requested

e2e/package.json Outdated Show resolved Hide resolved
@ozyx ozyx added this to the Target:4.0.0 milestone Jul 10, 2024
@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Jul 10, 2024
@ozyx ozyx self-requested a review July 11, 2024 20:51
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 15, 2024
@ozyx ozyx enabled auto-merge (squash) July 15, 2024 20:30
@ozyx ozyx merged commit 6983148 into nasa:master Jul 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:e2e:couchdb npm run test:e2e:couchdb source:community Community contribution or request type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants