-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(package.json): consistent props #7768
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7768 +/- ##
==========================================
- Coverage 56.66% 56.64% -0.02%
==========================================
Files 673 673
Lines 27177 27177
Branches 2636 2636
==========================================
- Hits 15399 15394 -5
- Misses 11447 11452 +5
Partials 331 331
see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@ozyx lmk if there's anything I need to do before it is mergeable :) |
Thanks @evenstensberg ! Really appreciate your patience with us. I'll have a look this afternoon. Cheers |
🌟 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change requested
a6fa73d
to
9fd727c
Compare
9fd727c
to
423990c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Describe your changes:
package.json in e2e and root metadata should be identical.
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist