Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Darkmatter] Style Changes Pt. 2 #7739

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

rukmini-bose
Copy link
Contributor

@rukmini-bose rukmini-bose commented Jun 3, 2024

Closes

Describe your changes:

  • Various fixes to style, color, font size, etc.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.91%. Comparing base (4ee68cc) to head (6f4ac30).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7739      +/-   ##
==========================================
- Coverage   57.21%   56.91%   -0.30%     
==========================================
  Files         674      674              
  Lines       27283    27283              
  Branches     2668     2668              
==========================================
- Hits        15609    15529      -80     
- Misses      11336    11416      +80     
  Partials      338      338              
Flag Coverage Δ
e2e-full 23.52% <ø> (-18.47%) ⬇️
e2e-stable 60.82% <ø> (-0.01%) ⬇️
unit 49.52% <ø> (ø)

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ee68cc...6f4ac30. Read the comment docs.

@rukmini-bose rukmini-bose marked this pull request as ready for review August 7, 2024 20:42
Copy link
Contributor

@charlesh88 charlesh88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants