Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add unused created attribute to metadata of couch documents on create #7656

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

davetsay
Copy link
Contributor

@davetsay davetsay commented Mar 29, 2024

Closes #7655

Describe your changes:

Removed line that adds metadata

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.10%. Comparing base (f98eb31) to head (6f004da).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7656      +/-   ##
==========================================
- Coverage   49.11%   49.10%   -0.01%     
==========================================
  Files         671      671              
  Lines       27116    27115       -1     
  Branches     2632     2632              
==========================================
- Hits        13318    13315       -3     
- Misses      13470    13472       +2     
  Partials      328      328              
Flag Coverage Δ
unit 49.10% <ø> (-0.01%) ⬇️
Files Coverage Δ
...c/plugins/persistence/couch/CouchObjectProvider.js 75.07% <ø> (-1.26%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f98eb31...6f004da. Read the comment docs.

@akhenry
Copy link
Contributor

akhenry commented Apr 4, 2024

@davetsay Is this ready for review?

@akhenry akhenry marked this pull request as ready for review April 4, 2024 20:14
@akhenry akhenry added the pr:e2e:couchdb npm run test:e2e:couchdb label Apr 4, 2024
@akhenry akhenry added this to the Target:4.0.0 milestone Apr 4, 2024
@akhenry akhenry self-requested a review April 4, 2024 20:21
@akhenry akhenry enabled auto-merge (squash) April 4, 2024 20:22
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Apr 4, 2024
@ozyx ozyx added the type:bug label Apr 4, 2024
@akhenry akhenry added the pr:e2e:couchdb npm run test:e2e:couchdb label Apr 4, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Apr 4, 2024
@akhenry akhenry merged commit e3adeb6 into master Apr 4, 2024
38 of 60 checks passed
@akhenry akhenry deleted the VIPEROMCT-513 branch April 4, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Couch persistence plugin should use Object API model.created standard rather than metadata.created
4 participants