Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mct7636 #7645

Merged
merged 7 commits into from
Mar 29, 2024
Merged

Mct7636 #7645

merged 7 commits into from
Mar 29, 2024

Conversation

jvigliotta
Copy link
Contributor

@jvigliotta jvigliotta commented Mar 26, 2024

Closes #7636

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes? (covered in: [Historical Telemetry Provider] Respect "order" request options akhenry/openmct-yamcs#455)
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.99%. Comparing base (a3fb84a) to head (b49664a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7645      +/-   ##
==========================================
+ Coverage   49.09%   49.99%   +0.89%     
==========================================
  Files         671      672       +1     
  Lines       27114    27122       +8     
  Branches     2632     2632              
==========================================
+ Hits        13312    13560     +248     
+ Misses      13474    13234     -240     
  Partials      328      328              
Flag Coverage Δ *Carryforward flag
e2e-full 23.64% <0.00%> (?) Carriedforward from 834b2d1
unit 49.08% <100.00%> (-0.02%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
src/plugins/telemetryTable/TelemetryTable.js 64.39% <100.00%> (+0.35%) ⬆️

... and 51 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3fb84a...b49664a. Read the comment docs.

@jvigliotta jvigliotta requested a review from akhenry March 27, 2024 17:01
@akhenry akhenry added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 29, 2024
@akhenry akhenry enabled auto-merge (squash) March 29, 2024 00:28
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 29, 2024
@akhenry akhenry merged commit 1671a58 into master Mar 29, 2024
19 checks passed
@akhenry akhenry deleted the mct7636 branch March 29, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telemetry tables are not requesting the correct sort order for limited mode
4 participants